This repository has been archived by the owner on May 21, 2019. It is now read-only.
Do not assume content of the SAMPLES_PROJECT_GLOB variable #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- samples folder may exist _only_ to enable use of a modified SAMPLES_PROJECT_GLOB
Other alternatives to the `Directory.Exists("samples")` approach:
- change default glob to something like `sam*ples/*/*.csproj`
- that wouldn't require the samples folder but may in the future match something unintended
- update PathResolver.shade in Sake to avoid `Directory.GetFiles(path, ...)` when path doesn't exist
- could copy PathResolver.shade into KoreBuild to avoid updating Sake
- but, this option can still hide real errors very easily
|
@natemcmaster and @pranavkm this fix is useful for aspnet/Performance#206. My builds currently leave many projects (those only built because they're referenced from a test) in a half-baked state. |
dougbu
commented
Feb 7, 2017
| } | ||
| if (!BuildSrcOnly && Directory.Exists("samples") && Directory.EnumerateFiles("samples", "*.csproj", SearchOption.AllDirectories).Any()) | ||
|
|
||
| if (!BuildSrcOnly && Directory.Exists("samples")) |
There was a problem hiding this comment.
Put another way, alright if we require an empty samples folder to enable SAMPLES_PROJECT_GLOB. But requiring a (no-op) project is a bit much.
dougbu
commented
Feb 7, 2017
| { | ||
| projectGlobs.AddRange(Files.Include(SAMPLES_PROJECT_GLOB).ToList()); | ||
| projectGlobs.AddRange(Files.Include(SAMPLES_PROJECT_GLOB).ToList()); |
There was a problem hiding this comment.
Note this line will still throw if SAMPLES_PROJECT_GLOB contains an entry that starts with a non-existent folder. One would hope those overriding this variable know what they're doing…
natemcmaster
approved these changes
Feb 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other alternatives to the
Directory.Exists("samples")approach:sam*ples/*/*.csprojDirectory.GetFiles(path, ...)when path doesn't exist